From: Geert Uytterhoeven Date: Thu, 16 Dec 2021 14:17:33 +0000 (+0100) Subject: serial: sh-sci: Use dev_err_probe() X-Git-Tag: v6.6.17~8431^2~49 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0d1bc829a755de826582c1c48ec40601d9b2fc29;p=platform%2Fkernel%2Flinux-rpi.git serial: sh-sci: Use dev_err_probe() Use the dev_err_probe() helper to streamline error handling. Reviewed-by: Laurent Pinchart Reviewed-by: Wolfram Sang Signed-off-by: Geert Uytterhoeven Link: https://lore.kernel.org/r/5c4dd8df1f8d0d14786f26ee80b77f3eb8e06cd5.1639663832.git.geert+renesas@glider.be Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/tty/serial/sh-sci.c b/drivers/tty/serial/sh-sci.c index f63b5a6..9b4afbb 100644 --- a/drivers/tty/serial/sh-sci.c +++ b/drivers/tty/serial/sh-sci.c @@ -2790,15 +2790,12 @@ static int sci_init_clocks(struct sci_port *sci_port, struct device *dev) * global "peripheral_clk" clock. */ clk = devm_clk_get(dev, "peripheral_clk"); - if (!IS_ERR(clk)) - goto found; - - dev_err(dev, "failed to get %s (%ld)\n", clk_names[i], - PTR_ERR(clk)); - return PTR_ERR(clk); + if (IS_ERR(clk)) + return dev_err_probe(dev, PTR_ERR(clk), + "failed to get %s\n", + clk_names[i]); } -found: if (IS_ERR(clk)) dev_dbg(dev, "failed to get %s (%ld)\n", clk_names[i], PTR_ERR(clk));