From: Roland Dreier Date: Wed, 31 Oct 2012 16:16:44 +0000 (-0700) Subject: target: Don't return success from module_init() if setup fails X-Git-Tag: v3.12-rc1~2008^2~3 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0d0f9dfb31e0a6c92063e235417b42df185b3275;p=kernel%2Fkernel-generic.git target: Don't return success from module_init() if setup fails If the call to core_dev_release_virtual_lun0() fails, then nothing sets ret to anything other than 0, so even though everything is torn down and freed, target_core_init_configfs() will seem to succeed and the module will be loaded. Fix this by passing the return value on up the chain. Signed-off-by: Roland Dreier Cc: stable@vger.kernel.org Signed-off-by: Nicholas Bellinger --- diff --git a/drivers/target/target_core_configfs.c b/drivers/target/target_core_configfs.c index 015f5be..c123327 100644 --- a/drivers/target/target_core_configfs.c +++ b/drivers/target/target_core_configfs.c @@ -3206,7 +3206,8 @@ static int __init target_core_init_configfs(void) if (ret < 0) goto out; - if (core_dev_setup_virtual_lun0() < 0) + ret = core_dev_setup_virtual_lun0(); + if (ret < 0) goto out; return 0;