From: Yu Kuai Date: Mon, 17 Aug 2020 11:57:26 +0000 (+0800) Subject: dmaengine: at_hdmac: check return value of of_find_device_by_node() in at_dma_xlate() X-Git-Tag: v5.15~2964^2~7 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0cef8e2c5a07d482ec907249dbd6687e8697677f;p=platform%2Fkernel%2Flinux-starfive.git dmaengine: at_hdmac: check return value of of_find_device_by_node() in at_dma_xlate() The reurn value of of_find_device_by_node() is not checked, thus null pointer dereference will be triggered if of_find_device_by_node() failed. Fixes: bbe89c8e3d59 ("at_hdmac: move to generic DMA binding") Signed-off-by: Yu Kuai Link: https://lore.kernel.org/r/20200817115728.1706719-2-yukuai3@huawei.com Signed-off-by: Vinod Koul --- diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c index 45bbcd6..1c941f8 100644 --- a/drivers/dma/at_hdmac.c +++ b/drivers/dma/at_hdmac.c @@ -1650,6 +1650,8 @@ static struct dma_chan *at_dma_xlate(struct of_phandle_args *dma_spec, return NULL; dmac_pdev = of_find_device_by_node(dma_spec->np); + if (!dmac_pdev) + return NULL; dma_cap_zero(mask); dma_cap_set(DMA_SLAVE, mask);