From: Axel Lin Date: Sun, 27 Jan 2013 12:54:40 +0000 (+0800) Subject: regulator: tps6507x: Fix using wrong dev argument for calling of_regulator_match X-Git-Tag: v3.9-rc1~154^2~1^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0ce7d00d0d7bc04d917b8775da177dde962ce17e;p=platform%2Fkernel%2Flinux-3.10.git regulator: tps6507x: Fix using wrong dev argument for calling of_regulator_match The dev parameter is the device requesting the data. In this case it should be &pdev->dev rather than pdev->dev.parent. The dev parameter is used to call devm_kzalloc in of_get_regulator_init_data(), which means this fixes a memory leak because the memory is allocated every time probe() is called, thus it should be freed when this driver is unloaded. Signed-off-by: Axel Lin Signed-off-by: Mark Brown --- diff --git a/drivers/regulator/tps6507x-regulator.c b/drivers/regulator/tps6507x-regulator.c index afdeb65..54aa2da 100644 --- a/drivers/regulator/tps6507x-regulator.c +++ b/drivers/regulator/tps6507x-regulator.c @@ -394,7 +394,7 @@ static struct tps6507x_board *tps6507x_parse_dt_reg_data( count = ARRAY_SIZE(tps6507x_matches); matches = tps6507x_matches; - ret = of_regulator_match(pdev->dev.parent, regulators, matches, count); + ret = of_regulator_match(&pdev->dev, regulators, matches, count); if (ret < 0) { dev_err(&pdev->dev, "Error parsing regulator init data: %d\n", ret);