From: Axel Lin <axel.lin@ingics.com>
Date: Fri, 14 Dec 2012 12:06:00 +0000 (+0000)
Subject: iio: dac: ad5504: Don't set error code to voltage_uv
X-Git-Tag: v3.8-rc5~39^2~2^2~6
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0ce2fdaa97c6a8d84e9fce3d920a45a493145623;p=profile%2Fivi%2Fkernel-x86-ivi.git

iio: dac: ad5504: Don't set error code to voltage_uv

regulator_get_voltage() may return negative error code.
Add error checking to avoid setting error code to voltage_uv.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
---

diff --git a/drivers/iio/dac/ad5504.c b/drivers/iio/dac/ad5504.c
index 242bdc7..7f7c026 100644
--- a/drivers/iio/dac/ad5504.c
+++ b/drivers/iio/dac/ad5504.c
@@ -296,7 +296,11 @@ static int __devinit ad5504_probe(struct spi_device *spi)
 		if (ret)
 			goto error_put_reg;
 
-		voltage_uv = regulator_get_voltage(reg);
+		ret = regulator_get_voltage(reg);
+		if (ret < 0)
+			goto error_disable_reg;
+
+		voltage_uv = ret;
 	}
 
 	spi_set_drvdata(spi, indio_dev);