From: subhransu mohanty <sub.mohanty@samsung.com>
Date: Fri, 29 Nov 2019 06:34:22 +0000 (+0900)
Subject: rlottie: update the drawable before returning the result.
X-Git-Tag: submit/tizen/20191201.211113~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0cd7b5c1e204aec8191abf012d5927b224902c1f;p=platform%2Fcore%2Fuifw%2Flottie-player.git

rlottie: update the drawable before returning the result.

If the drawable is not updated in case of ZERO opacity it will keep the old value and
will render the old content.
---

diff --git a/src/lottie/lottieitem.cpp b/src/lottie/lottieitem.cpp
index e4abc39..292d26c 100644
--- a/src/lottie/lottieitem.cpp
+++ b/src/lottie/lottieitem.cpp
@@ -1204,13 +1204,11 @@ bool LOTFillItem::updateContent(int frameNo, const VMatrix &, float alpha)
     auto combinedAlpha = alpha * mModel.opacity(frameNo);
     auto color = mModel.color(frameNo).toColor(combinedAlpha);
 
-    if (color.isTransparent()) return false;
-
     VBrush brush(color);
     mDrawable.setBrush(brush);
     mDrawable.setFillRule(mModel.fillRule());
 
-    return true;
+    return !color.isTransparent();
 }
 
 LOTGFillItem::LOTGFillItem(LOTGFillData *data)
@@ -1221,7 +1219,6 @@ LOTGFillItem::LOTGFillItem(LOTGFillData *data)
 bool LOTGFillItem::updateContent(int frameNo, const VMatrix &matrix, float alpha)
 {
     float combinedAlpha = alpha * mData->opacity(frameNo);
-    if (vIsZero(combinedAlpha)) return false;
 
     mData->update(mGradient, frameNo);
     mGradient->setAlpha(combinedAlpha);
@@ -1229,7 +1226,7 @@ bool LOTGFillItem::updateContent(int frameNo, const VMatrix &matrix, float alpha
     mDrawable.setBrush(VBrush(mGradient.get()));
     mDrawable.setFillRule(mData->fillRule());
 
-    return true;
+    return !vIsZero(combinedAlpha);
 }
 
 LOTStrokeItem::LOTStrokeItem(LOTStrokeData *data)
@@ -1249,8 +1246,6 @@ bool LOTStrokeItem::updateContent(int frameNo, const VMatrix &matrix, float alph
     auto combinedAlpha = alpha * mModel.opacity(frameNo);
     auto color = mModel.color(frameNo).toColor(combinedAlpha);
 
-    if (color.isTransparent()) return false;
-
     VBrush brush(color);
     mDrawable.setBrush(brush);
     float scale = matrix.scale();
@@ -1266,7 +1261,7 @@ bool LOTStrokeItem::updateContent(int frameNo, const VMatrix &matrix, float alph
         }
     }
 
-    return true;
+    return !color.isTransparent();
 }
 
 LOTGStrokeItem::LOTGStrokeItem(LOTGStrokeData *data)
@@ -1282,7 +1277,6 @@ LOTGStrokeItem::LOTGStrokeItem(LOTGStrokeData *data)
 bool LOTGStrokeItem::updateContent(int frameNo, const VMatrix &matrix, float alpha)
 {
     float combinedAlpha = alpha * mData->opacity(frameNo);
-    if (vIsZero(combinedAlpha)) return false;
 
     mData->update(mGradient, frameNo);
     mGradient->setAlpha(combinedAlpha);
@@ -1301,7 +1295,7 @@ bool LOTGStrokeItem::updateContent(int frameNo, const VMatrix &matrix, float alp
         }
     }
 
-    return true;
+    return !vIsZero(combinedAlpha);
 }
 
 LOTTrimItem::LOTTrimItem(LOTTrimData *data)