From: Colin Ian King <colin.king@canonical.com>
Date: Sat, 8 Feb 2020 22:20:06 +0000 (+0000)
Subject: ALSA: hdsp: remove redundant assignment to variable err
X-Git-Tag: v5.15~2585^2~246^2~30
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0cc629722221701a1b1030477c44dfbaca6c110d;p=platform%2Fkernel%2Flinux-starfive.git

ALSA: hdsp: remove redundant assignment to variable err

Variable err is being assigned with a value that is never read, it is
assigned a new value in the next statement. The assignment is redundant
and can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Link: https://lore.kernel.org/r/20200208222006.37376-1-colin.king@canonical.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---

diff --git a/sound/pci/rme9652/hdsp.c b/sound/pci/rme9652/hdsp.c
index cc06f0a..227aece 100644
--- a/sound/pci/rme9652/hdsp.c
+++ b/sound/pci/rme9652/hdsp.c
@@ -3353,7 +3353,8 @@ snd_hdsp_proc_read(struct snd_info_entry *entry, struct snd_info_buffer *buffer)
 				return;
 			}
 		} else {
-			int err = -EINVAL;
+			int err;
+
 			err = hdsp_request_fw_loader(hdsp);
 			if (err < 0) {
 				snd_iprintf(buffer,