From: Linus Walleij Date: Tue, 22 Dec 2015 14:48:33 +0000 (+0100) Subject: mfd: ucb1x00-core: Be sure to clamp return value X-Git-Tag: v4.14-rc1~4024^2~30 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0c7f3f92ffe8dc4e631b2f20c06543ec9f521f7c;p=platform%2Fkernel%2Flinux-rpi.git mfd: ucb1x00-core: Be sure to clamp return value As we want gpio_chip .get() calls to be able to return negative error codes and propagate to drivers, we need to go over all drivers and make sure their return values are clamped to [0,1]. We do this by using the ret = !!(val) design pattern. Cc: Lee Jones Signed-off-by: Linus Walleij Signed-off-by: Lee Jones --- diff --git a/drivers/mfd/ucb1x00-core.c b/drivers/mfd/ucb1x00-core.c index f691d7e..e0dd83f 100644 --- a/drivers/mfd/ucb1x00-core.c +++ b/drivers/mfd/ucb1x00-core.c @@ -133,7 +133,7 @@ static int ucb1x00_gpio_get(struct gpio_chip *chip, unsigned offset) val = ucb1x00_reg_read(ucb, UCB_IO_DATA); ucb1x00_disable(ucb); - return val & (1 << offset); + return !!(val & (1 << offset)); } static int ucb1x00_gpio_direction_input(struct gpio_chip *chip, unsigned offset)