From: Steven Whitehouse <swhiteho@redhat.com>
Date: Thu, 30 Apr 2009 13:52:58 +0000 (+0100)
Subject: GFS2: Fix glock ref counting bug
X-Git-Tag: v3.12-rc1~14602^2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0c7a531a200480c7bc447260376973d830da9069;p=kernel%2Fkernel-generic.git

GFS2: Fix glock ref counting bug

Depending on the ordering of events as we go around the
glock shrinker loop, it is possible to drop the ref count
of a glock incorrectly. It doesn't happen very often. This
patch corrects the got_ref variable, fixing the problem.

Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
---

diff --git a/fs/gfs2/glock.c b/fs/gfs2/glock.c
index 1afd9f2..ff49810 100644
--- a/fs/gfs2/glock.c
+++ b/fs/gfs2/glock.c
@@ -1304,6 +1304,7 @@ static int gfs2_shrink_glock_memory(int nr, gfp_t gfp_mask)
 				nr--;
 				if (queue_delayed_work(glock_workqueue, &gl->gl_work, 0) == 0)
 					gfs2_glock_put(gl);
+				got_ref = 0;
 			}
 			spin_lock(&lru_lock);
 			if (may_demote)