From: Peter Hutterer <peter.hutterer@who-t.net>
Date: Tue, 22 Oct 2024 02:15:04 +0000 (+1000)
Subject: pad: don't print a clobbered errno
X-Git-Tag: 1.27.0~63
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0c782c4084239d03ed7cb4469a8d9748f8f94b13;p=platform%2Fupstream%2Flibinput.git

pad: don't print a clobbered errno

is_litest_device() may change errno since it calls into libudev.

Part-of: <https://gitlab.freedesktop.org/libinput/libinput/-/merge_requests/1069>
---

diff --git a/src/evdev-tablet-pad-leds.c b/src/evdev-tablet-pad-leds.c
index 7419bb5b..93278b44 100644
--- a/src/evdev-tablet-pad-leds.c
+++ b/src/evdev-tablet-pad-leds.c
@@ -213,15 +213,15 @@ pad_group_new(struct pad_dispatch *pad,
 		struct pad_mode_led *led;
 
 		led = pad_led_new(libinput, syspath, group_index, nleds);
-		if (!led)
+		if (!led) {
+			rc = -errno;
 			goto error;
-
+		}
 		list_insert(&group->led_list, &led->link);
 	}
 
 	rc = pad_led_group_get_mode(group);
 	if (rc < 0) {
-		errno = -rc;
 		goto error;
 	}
 
@@ -233,7 +233,7 @@ error:
 	if (!is_litest_device(pad->device))
 		evdev_log_error(pad->device,
 				"unable to init LED group: %s\n",
-				strerror(errno));
+				strerror(-rc));
 	pad_led_group_destroy(&group->base);
 
 	return NULL;