From: NeilBrown Date: Mon, 25 Nov 2013 00:12:43 +0000 (+1100) Subject: md/raid5: fix new memory-reference bug in alloc_thread_groups. X-Git-Tag: v3.13-rc2~11^2~2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0c775d5208284700de423e6746259da54a42e1f5;p=profile%2Fivi%2Fkernel-x86-ivi.git md/raid5: fix new memory-reference bug in alloc_thread_groups. In alloc_thread_groups, worker_groups is a pointer to an array, not an array of pointers. So worker_groups[i] is wrong. It should be &(*worker_groups)[i] Found-by: coverity Fixes: 60aaf9338545 Reported-by: Ben Hutchings Cc: majianpeng Signed-off-by: NeilBrown --- diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c index 47da0af..676d8b7 100644 --- a/drivers/md/raid5.c +++ b/drivers/md/raid5.c @@ -5471,7 +5471,7 @@ static int alloc_thread_groups(struct r5conf *conf, int cnt, for (i = 0; i < *group_cnt; i++) { struct r5worker_group *group; - group = worker_groups[i]; + group = &(*worker_groups)[i]; INIT_LIST_HEAD(&group->handle_list); group->conf = conf; group->workers = workers + i * cnt;