From: 박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 <jh1302.park@samsung.com>
Date: Wed, 17 Oct 2018 05:18:12 +0000 (+0900)
Subject: [coco] Rename local variables in Def test (#1887)
X-Git-Tag: nncc_backup~1515
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0c6032b532b3c0d3025fb4150c13cc05b58d21b6;p=platform%2Fcore%2Fml%2Fnnfw.git

[coco] Rename local variables in Def test (#1887)

Def test current includes several local variables whose name is
counter-intuitive.

This commit renames these variables in order to make it easy to
understand the test.

Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
---

diff --git a/contrib/coco/core/src/IR/Def.test.cpp b/contrib/coco/core/src/IR/Def.test.cpp
index 41c06e6..8f9b378 100644
--- a/contrib/coco/core/src/IR/Def.test.cpp
+++ b/contrib/coco/core/src/IR/Def.test.cpp
@@ -40,32 +40,26 @@ TEST_F(DefTest, constructor)
 {
   auto o = obj_mgr.create(nncc::core::ADT::feature::Shape{1, 1, 1});
 
-  // TODO Rename 'def'
-  ::mock::Producer def;
+  ::mock::Producer producer;
+  coco::Def def{&producer};
 
-  // TODO Rename 'slot'
-  coco::Def slot{&def};
-
-  ASSERT_EQ(slot.value(), nullptr);
+  ASSERT_EQ(def.value(), nullptr);
 }
 
 TEST_F(DefTest, value)
 {
   auto o = obj_mgr.create(nncc::core::ADT::feature::Shape{1, 1, 1});
 
-  // TODO Rename 'def'
-  ::mock::Producer def;
-
-  // TODO Rename 'slot'
-  coco::Def slot{&def};
+  ::mock::Producer producer;
+  coco::Def def{&producer};
 
-  slot.value(o);
+  def.value(o);
 
-  ASSERT_EQ(slot.value(), o);
+  ASSERT_EQ(def.value(), o);
 
-  ASSERT_EQ(o->def(), &slot);
+  ASSERT_EQ(o->def(), &def);
 
-  slot.value(nullptr);
+  def.value(nullptr);
 
   ASSERT_EQ(o->def(), nullptr);
 }
@@ -74,17 +68,14 @@ TEST_F(DefTest, unlink_on_destruction)
 {
   auto o = obj_mgr.create(nncc::core::ADT::feature::Shape{1, 1, 1});
 
-  // TODO Rename 'def'
-  ::mock::Producer def;
-
-  // TODO Rename 'slot'
-  auto slot = make_unique<coco::Def>(&def);
+  ::mock::Producer producer;
+  auto def = make_unique<coco::Def>(&producer);
 
-  slot->value(o);
-  ASSERT_EQ(o->def(), slot.get());
+  def->value(o);
+  ASSERT_EQ(o->def(), def.get());
 
   // Let's destruct the allocated slot
-  slot.reset(nullptr);
+  def.reset(nullptr);
 
   // The def of Object SHOULD BE updated
   ASSERT_EQ(o->def(), nullptr);