From: Mart Raudsepp <mart.raudsepp@collabora.com>
Date: Fri, 12 Apr 2019 14:30:14 +0000 (+0300)
Subject: track: Avoid various sorting operations before timeline commit
X-Git-Tag: 1.19.3~493^2~516
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0c592ad6acaac2e6b65586232e7849218c652b39;p=platform%2Fupstream%2Fgstreamer.git

track: Avoid various sorting operations before timeline commit

These are showing up in performance profile of 1000+ clips looped addition.
All this is done at commit time as well, so let that do only one update and
sorting.
---

diff --git a/ges/ges-track.c b/ges/ges-track.c
index b23d47c..3cb3859 100644
--- a/ges/ges-track.c
+++ b/ges/ges-track.c
@@ -281,14 +281,6 @@ update_field (GQuark field_id, const GValue * value, GstStructure * original)
 
 /* callbacks */
 static void
-sort_track_elements_cb (GESTrackElement * child,
-    GParamSpec * arg G_GNUC_UNUSED, GESTrack * track)
-{
-  g_sequence_sort (track->priv->trackelements_by_start,
-      (GCompareDataFunc) element_start_compare, NULL);
-}
-
-static void
 _ghost_nlecomposition_srcpad (GESTrack * track)
 {
   GstPad *capsfilter_sink;
@@ -380,8 +372,6 @@ remove_object_internal (GESTrack * track, GESTrackElement * object)
     }
   }
 
-  g_signal_handlers_disconnect_by_func (object, sort_track_elements_cb, NULL);
-
   ges_track_element_set_track (object, NULL);
   ges_timeline_element_set_timeline (GES_TIMELINE_ELEMENT (object), NULL);
 
@@ -987,15 +977,6 @@ ges_track_add_element (GESTrack * track, GESTrackElement * object)
   g_signal_emit (track, ges_track_signals[TRACK_ELEMENT_ADDED], 0,
       GES_TRACK_ELEMENT (object));
 
-  g_signal_connect (GES_TRACK_ELEMENT (object), "notify::start",
-      G_CALLBACK (sort_track_elements_cb), track);
-
-  g_signal_connect (GES_TRACK_ELEMENT (object), "notify::duration",
-      G_CALLBACK (sort_track_elements_cb), track);
-
-  g_signal_connect (GES_TRACK_ELEMENT (object), "notify::priority",
-      G_CALLBACK (sort_track_elements_cb), track);
-
   return TRUE;
 }
 
@@ -1052,7 +1033,6 @@ ges_track_remove_element (GESTrack * track, GESTrackElement * object)
 
   it = g_hash_table_lookup (priv->trackelements_iter, object);
   g_sequence_remove (it);
-  track_resort_and_fill_gaps (track);
 
   if (remove_object_internal (track, object) == TRUE) {
     ges_timeline_element_set_timeline (GES_TIMELINE_ELEMENT (object), NULL);