From: Lennart Poettering Date: Mon, 16 Nov 2015 23:16:21 +0000 (+0100) Subject: sd-ipv4ll: fix error path if sd-ipv4acd allocation fails X-Git-Tag: v228~8^2~4 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0c28d28834f71e74d5a2d8bcfb19938a34396036;p=platform%2Fupstream%2Fsystemd.git sd-ipv4ll: fix error path if sd-ipv4acd allocation fails Let's make sure the destructor cannot hit the n_ref == 0 case. --- diff --git a/src/libsystemd-network/sd-ipv4ll.c b/src/libsystemd-network/sd-ipv4ll.c index 006db6f..30a7ef5 100644 --- a/src/libsystemd-network/sd-ipv4ll.c +++ b/src/libsystemd-network/sd-ipv4ll.c @@ -101,6 +101,8 @@ int sd_ipv4ll_new(sd_ipv4ll **ret) { if (!ll) return -ENOMEM; + ll->n_ref = 1; + r = sd_ipv4acd_new(&ll->acd); if (r < 0) return r; @@ -109,8 +111,6 @@ int sd_ipv4ll_new(sd_ipv4ll **ret) { if (r < 0) return r; - ll->n_ref = 1; - *ret = ll; ll = NULL;