From: Ming Lei <ming.lei@canonical.com>
Date: Sat, 4 Aug 2012 04:01:18 +0000 (+0800)
Subject: firmware loader: remove unnecessary wmb()
X-Git-Tag: upstream/snapshot3+hdmi~6594^2~85
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0c25a850f7f336cd3bf2b0a479fe70cecb242c6e;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git

firmware loader: remove unnecessary wmb()

The wmb() inside fw_load_abort is not necessary, since
complete() and wait_on_completion() has implied one pair
of memory barrier.

Also wmb() isn't a correct usage, so just remove it.

Signed-off-by: Ming Lei <ming.lei@canonical.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c
index 1915ad8..0bd09c7 100644
--- a/drivers/base/firmware_class.c
+++ b/drivers/base/firmware_class.c
@@ -112,7 +112,6 @@ static struct firmware_priv *to_firmware_priv(struct device *dev)
 static void fw_load_abort(struct firmware_priv *fw_priv)
 {
 	set_bit(FW_STATUS_ABORT, &fw_priv->status);
-	wmb();
 	complete(&fw_priv->completion);
 }