From: Jooseok Song Date: Mon, 4 Sep 2017 09:49:02 +0000 (+0900) Subject: Fix dispose and wrong statement in comment X-Git-Tag: preview1-00152^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0c1fcf61ddaadf61058534471c8d9e33df5b4b25;p=platform%2Fcore%2Fcsapi%2Ftizenfx.git Fix dispose and wrong statement in comment Change-Id: I264b7d15a9cb6147411f3d30fb07e233bdd58ba0 --- diff --git a/src/Tizen.Account.AccountManager/Tizen.Account.AccountManager/Account.cs b/src/Tizen.Account.AccountManager/Tizen.Account.AccountManager/Account.cs index 498bb849e..b09639fd7 100644 --- a/src/Tizen.Account.AccountManager/Tizen.Account.AccountManager/Account.cs +++ b/src/Tizen.Account.AccountManager/Tizen.Account.AccountManager/Account.cs @@ -27,6 +27,11 @@ namespace Tizen.Account.AccountManager { private readonly SafeAccountHandle _handle; + /// + /// Account constructor. + /// + /// 4 + /// The account handle. public Account(SafeAccountHandle handle) { _handle = handle; @@ -607,16 +612,11 @@ namespace Tizen.Account.AccountManager GC.SuppressFinalize(this); } - private void Dispose(bool disposing) + protected virtual void Dispose(bool disposing) { if (!disposing) { - //if (_handle != IntPtr.Zero) - //{ - // _handle = IntPtr.Zero; - //} - //_handle.Dispose(); - GC.SuppressFinalize(this); + _handle.Dispose(); } } } diff --git a/src/Tizen.Account.AccountManager/Tizen.Account.AccountManager/AccountEnums.cs b/src/Tizen.Account.AccountManager/Tizen.Account.AccountManager/AccountEnums.cs index 68a7a6518..53942e079 100644 --- a/src/Tizen.Account.AccountManager/Tizen.Account.AccountManager/AccountEnums.cs +++ b/src/Tizen.Account.AccountManager/Tizen.Account.AccountManager/AccountEnums.cs @@ -96,7 +96,7 @@ namespace Tizen.Account.AccountManager Idle, /// - /// Acount sync supported and sync status is running. + /// Account sync supported and sync status is running. /// /// 3 Running diff --git a/src/Tizen.Account.AccountManager/Tizen.Account.AccountManager/AccountErrorFactory.cs b/src/Tizen.Account.AccountManager/Tizen.Account.AccountManager/AccountErrorFactory.cs index 51c31ddb0..f23c792cd 100644 --- a/src/Tizen.Account.AccountManager/Tizen.Account.AccountManager/AccountErrorFactory.cs +++ b/src/Tizen.Account.AccountManager/Tizen.Account.AccountManager/AccountErrorFactory.cs @@ -20,7 +20,7 @@ using Tizen; namespace Tizen.Account.AccountManager { /// - /// Enumeration for the types of error occured, if any. + /// Enumeration for the types of error occurred, if any. /// /// 3 public enum AccountError @@ -45,7 +45,7 @@ namespace Tizen.Account.AccountManager /// Same user name exists in your application. /// /// 3 - Duplcated = -0x01000000 | 0x01, + Duplicated = -0x01000000 | 0x01, /// /// Empty data. /// diff --git a/src/Tizen.Account.AccountManager/Tizen.Account.AccountManager/AccountProvider.cs b/src/Tizen.Account.AccountManager/Tizen.Account.AccountManager/AccountProvider.cs index ce34491a6..be9e07768 100644 --- a/src/Tizen.Account.AccountManager/Tizen.Account.AccountManager/AccountProvider.cs +++ b/src/Tizen.Account.AccountManager/Tizen.Account.AccountManager/AccountProvider.cs @@ -69,7 +69,7 @@ namespace Tizen.Account.AccountManager } /// - /// Serviceprovider ID of the account provider. + /// ServiceProvider ID of the account provider. /// /// 3 public string ServiceProviderId @@ -365,7 +365,7 @@ namespace Tizen.Account.AccountManager GC.SuppressFinalize(this); } - private void Dispose(bool disposing) + protected virtual void Dispose(bool disposing) { if (!disposing) { diff --git a/src/Tizen.Account.AccountManager/Tizen.Account.AccountManager/AccountService.cs b/src/Tizen.Account.AccountManager/Tizen.Account.AccountManager/AccountService.cs index d335a8e1d..8ebab51fa 100644 --- a/src/Tizen.Account.AccountManager/Tizen.Account.AccountManager/AccountService.cs +++ b/src/Tizen.Account.AccountManager/Tizen.Account.AccountManager/AccountService.cs @@ -200,7 +200,7 @@ namespace Tizen.Account.AccountManager /// The AccountProvider instance associated with the given application ID. /// http://tizen.org/privilege/account.read /// http://tizen.org/feature/account - /// In case of any DB error or record not found for given appid. + /// In case of any DB error or record not found for given appId. /// In case of an invalid parameter. /// In case of privilege not defined. /// The required feature is not supported. @@ -262,6 +262,7 @@ namespace Tizen.Account.AccountManager /// /// 3 /// New Account instance to be added. + /// The account ID of the account instance. /// http://tizen.org/privilege/account.read /// http://tizen.org/privilege/account.write /// http://tizen.org/feature/account @@ -590,9 +591,9 @@ namespace Tizen.Account.AccountManager /// /// 3 /// - /// ContentUpdate event is triggered if the MediaInformaion updated/deleted or new information is inserted. + /// ContentUpdate event is triggered if the MediaInformation updated/deleted or new information is inserted. /// - /// + /// An object that contains information about sender /// A ContentUpdatedEventArgs object that contains information about the update operation. /// http://tizen.org/privilege/account.read /// http://tizen.org/feature/account