From: Xavier Claessens <xavier.claessens@collabora.com>
Date: Wed, 14 Aug 2019 15:21:30 +0000 (-0400)
Subject: amc: Fix crash when a sync_meta survives its sink
X-Git-Tag: 1.16.2~46
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0c1639546b3d04a1a2a8ade00c1ed3b4c41c0623;p=platform%2Fupstream%2Fgst-plugins-bad.git

amc: Fix crash when a sync_meta survives its sink

_amc_gl_free() could be called after the GstAmcVideoDec has been
finalized, in the case downstream still has a ref to a buffer.
---

diff --git a/sys/androidmedia/gstamcvideodec.c b/sys/androidmedia/gstamcvideodec.c
index 168165010..6ca6dd2fd 100644
--- a/sys/androidmedia/gstamcvideodec.c
+++ b/sys/androidmedia/gstamcvideodec.c
@@ -153,6 +153,7 @@ _gl_sync_unref (struct gl_sync *sync)
 
     _gl_sync_result_unref (sync->result);
 
+    g_object_unref (sync->sink);
     g_object_unref (sync->surface);
     gst_memory_unref ((GstMemory *) sync->oes_mem);
 
@@ -1464,7 +1465,7 @@ retry:
 
     sync = g_new0 (struct gl_sync, 1);
     sync->refcount = 1;
-    sync->sink = self;
+    sync->sink = g_object_ref (self);
     sync->buffer = outbuf;
     sync->surface = g_object_ref (self->surface);
     sync->oes_mem =