From: H Hartley Sweeten Date: Fri, 8 Jun 2012 00:31:19 +0000 (-0700) Subject: staging: comedi: adl_pci9118: if test should use logical AND not bitwise AND X-Git-Tag: v3.6-rc1~100^2~868 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0bdf8ec0a57e5c4f90f4d6e83938f24653360d84;p=platform%2Fkernel%2Flinux-3.10.git staging: comedi: adl_pci9118: if test should use logical AND not bitwise AND This quiets a couple sparse warnings about: warning: dubious: !x & y Also, remove the unnecessary parentheses around the variables. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Mori Hess Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c b/drivers/staging/comedi/drivers/adl_pci9118.c index 3670ebd..5a5c903 100644 --- a/drivers/staging/comedi/drivers/adl_pci9118.c +++ b/drivers/staging/comedi/drivers/adl_pci9118.c @@ -1735,7 +1735,7 @@ static int check_channel_list(struct comedi_device *dev, "can't be mixtured!"); return 0; } - if ((!devpriv->usemux) & (differencial) & + if (!devpriv->usemux && differencial && (CR_CHAN(chanlist[i]) >= this_board->n_aichand)) { comedi_error(dev, "If AREF_DIFF is used then is "