From: Christophe JAILLET Date: Tue, 8 Dec 2020 20:35:27 +0000 (+0100) Subject: mmc: mxs-mmc: Fix a resource leak in an error handling path in 'mxs_mmc_probe()' X-Git-Tag: v5.15~1722^2~86 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0bb7e560f821c7770973a94e346654c4bdccd42c;p=platform%2Fkernel%2Flinux-starfive.git mmc: mxs-mmc: Fix a resource leak in an error handling path in 'mxs_mmc_probe()' If 'mmc_of_parse()' fails, we must undo the previous 'dma_request_chan()' call. Signed-off-by: Christophe JAILLET Link: https://lore.kernel.org/r/20201208203527.49262-1-christophe.jaillet@wanadoo.fr Signed-off-by: Ulf Hansson --- diff --git a/drivers/mmc/host/mxs-mmc.c b/drivers/mmc/host/mxs-mmc.c index 56bbc6c..947581d 100644 --- a/drivers/mmc/host/mxs-mmc.c +++ b/drivers/mmc/host/mxs-mmc.c @@ -628,7 +628,7 @@ static int mxs_mmc_probe(struct platform_device *pdev) ret = mmc_of_parse(mmc); if (ret) - goto out_clk_disable; + goto out_free_dma; mmc->ocr_avail = MMC_VDD_32_33 | MMC_VDD_33_34;