From: Dan Carpenter <error27@gmail.com>
Date: Tue, 10 Aug 2010 05:36:24 +0000 (+0200)
Subject: Staging: ti-st: writing past end of array
X-Git-Tag: v2.6.37-rc1~60^2~3^2~768
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0b6e7220ed2be6e40bbda4eeb2b9c397008f2cef;p=profile%2Fivi%2Fkernel-x86-ivi.git

Staging: ti-st: writing past end of array

In the original source it would write past the end of the array before
returning the error code.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---

diff --git a/drivers/staging/ti-st/st_core.c b/drivers/staging/ti-st/st_core.c
index 063c9b1..0dfed21 100644
--- a/drivers/staging/ti-st/st_core.c
+++ b/drivers/staging/ti-st/st_core.c
@@ -686,9 +686,8 @@ long st_register(struct st_proto_s *new_proto)
 		default:
 			pr_err("%d protocol not supported",
 				   new_proto->type);
-			err = -EPROTONOSUPPORT;
-			/* something wrong */
-			break;
+			spin_unlock_irqrestore(&st_gdata->lock, flags);
+			return -EPROTONOSUPPORT;
 		}
 		st_gdata->list[new_proto->type] = new_proto;
 		st_gdata->protos_registered++;