From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 8 Nov 2013 09:43:17 +0000 (-0800)
Subject: usb: phy: twl6030-usb: signedness bug in twl6030_readb()
X-Git-Tag: v3.13-rc5~24^2~10^2~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0b55149033403d78f345fb613d8ad52d16c161fc;p=kernel%2Fkernel-generic.git

usb: phy: twl6030-usb: signedness bug in twl6030_readb()

"ret" needs to be signed for the error handling to work.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
---

diff --git a/drivers/usb/phy/phy-twl6030-usb.c b/drivers/usb/phy/phy-twl6030-usb.c
index 30e8a61..bad57ce 100644
--- a/drivers/usb/phy/phy-twl6030-usb.c
+++ b/drivers/usb/phy/phy-twl6030-usb.c
@@ -127,7 +127,8 @@ static inline int twl6030_writeb(struct twl6030_usb *twl, u8 module,
 
 static inline u8 twl6030_readb(struct twl6030_usb *twl, u8 module, u8 address)
 {
-	u8 data, ret = 0;
+	u8 data;
+	int ret;
 
 	ret = twl_i2c_read_u8(module, &data, address);
 	if (ret >= 0)