From: zhujun2 <zhujun2@cmss.chinamobile.com>
Date: Wed, 18 Oct 2023 01:59:21 +0000 (-0700)
Subject: selftests/efivarfs: create-read: fix a resource leak
X-Git-Tag: v6.1.68~703
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0aaf8077564e0c149d7d0294a202d7263ae3655d;p=platform%2Fkernel%2Flinux-starfive.git

selftests/efivarfs: create-read: fix a resource leak

[ Upstream commit 3f6f8a8c5e11a9b384a36df4f40f0c9a653b6975 ]

The opened file should be closed in main(), otherwise resource
leak will occur that this problem was discovered by code reading

Signed-off-by: zhujun2 <zhujun2@cmss.chinamobile.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---

diff --git a/tools/testing/selftests/efivarfs/create-read.c b/tools/testing/selftests/efivarfs/create-read.c
index 9674a19..7bc7af4 100644
--- a/tools/testing/selftests/efivarfs/create-read.c
+++ b/tools/testing/selftests/efivarfs/create-read.c
@@ -32,8 +32,10 @@ int main(int argc, char **argv)
 	rc = read(fd, buf, sizeof(buf));
 	if (rc != 0) {
 		fprintf(stderr, "Reading a new var should return EOF\n");
+		close(fd);
 		return EXIT_FAILURE;
 	}
 
+	close(fd);
 	return EXIT_SUCCESS;
 }