From: Daniel Mack <daniel@zonque.org>
Date: Tue, 22 Dec 2015 10:32:25 +0000 (+0100)
Subject: socket: nullify pointers after free
X-Git-Tag: v231~837^2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0a78712e819f2db29809ec752bf96c2c1012a181;p=platform%2Fupstream%2Fsystemd.git

socket: nullify pointers after free

A socket shouldn't be used after socket_done() returns, but follow the
general guideline here and avoid dangling pointers anyway.
---

diff --git a/src/core/socket.c b/src/core/socket.c
index fb7632d..d6b0c96 100644
--- a/src/core/socket.c
+++ b/src/core/socket.c
@@ -156,14 +156,14 @@ static void socket_done(Unit *u) {
         s->tcp_congestion = mfree(s->tcp_congestion);
         s->bind_to_device = mfree(s->bind_to_device);
 
-        free(s->smack);
-        free(s->smack_ip_in);
-        free(s->smack_ip_out);
+        s->smack = mfree(s->smack);
+        s->smack_ip_in = mfree(s->smack_ip_in);
+        s->smack_ip_out = mfree(s->smack_ip_out);
 
         strv_free(s->symlinks);
 
-        free(s->user);
-        free(s->group);
+        s->user = mfree(s->user);
+        s->group = mfree(s->group);
 
         s->fdname = mfree(s->fdname);