From: Nicholas Clark <nick@ccl4.org>
Date: Tue, 14 Dec 2010 15:43:02 +0000 (+0000)
Subject: In Fcntl's syslfs.t and t/op/lfs.t, eliminate zap().
X-Git-Tag: accepted/trunk/20130322.191538~6493
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=09eb7cfbca20b4071e1b90c66713173d118d1d47;p=platform%2Fupstream%2Fperl.git

In Fcntl's syslfs.t and t/op/lfs.t, eliminate zap().

Now that we're using tempfiles, it no longer contains code to unlink the test
files, only a close. Inline the C<close BIG> into bye(), and remove the other
call to zap(), which was immediately after an explicit close of BIG.
---

diff --git a/ext/Fcntl/t/syslfs.t b/ext/Fcntl/t/syslfs.t
index c6252cc..e5996b3 100644
--- a/ext/Fcntl/t/syslfs.t
+++ b/ext/Fcntl/t/syslfs.t
@@ -22,12 +22,8 @@ our $fail;
 (undef, my $big1) = tempfile(UNLINK => 1);
 (undef, my $big2) = tempfile(UNLINK => 1);
 
-sub zap {
-    close(BIG);
-}
-
 sub bye {
-    zap(); 
+    close(BIG);
     exit(0);
 }
 
@@ -108,8 +104,6 @@ my @s2 = stat($big2);
 
 print "# s2 = @s2\n";
 
-zap();
-
 unless ($s1[7] == 1_000_003 && $s2[7] == 2_000_003 &&
 	$s1[11] == $s2[11] && $s1[12] == $s2[12] &&
 	$s1[12] > 0) {
diff --git a/t/op/lfs.t b/t/op/lfs.t
index 67e4f64..cf7a364 100644
--- a/t/op/lfs.t
+++ b/t/op/lfs.t
@@ -23,12 +23,8 @@ my $big0 = tempfile();
 my $big1 = tempfile();
 my $big2 = tempfile();
 
-sub zap {
-    close(BIG);
-}
-
 sub bye {
-    zap(); 
+    close(BIG);
     exit(0);
 }
 
@@ -119,8 +115,6 @@ my @s2 = stat($big2);
 
 print "# s2 = @s2\n";
 
-zap();
-
 unless ($s1[7] == 1_000_003 && $s2[7] == 2_000_003 &&
 	$s1[11] == $s2[11] && $s1[12] == $s2[12] &&
 	$s1[12] > 0) {