From: David Howells Date: Tue, 28 Apr 2015 14:36:36 +0000 (+0100) Subject: crypto: testmgr - Wrap the LHS in expressions of the form !x == y X-Git-Tag: v4.9.8~4102^2~228 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=09e217844a2e2d02a950bc9c129f6fe423e426e0;p=platform%2Fkernel%2Flinux-rpi3.git crypto: testmgr - Wrap the LHS in expressions of the form !x == y In the test manager, there are a number of if-statements with expressions of the form !x == y that incur warnings with gcc-5 of the following form: ../crypto/testmgr.c: In function '__test_aead': ../crypto/testmgr.c:523:12: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses] if (!ret == template[i].fail) { ^ By converting the 'fail' member of struct aead_testvec and struct cipher_testvec to a bool, we can get rid of the warnings. Signed-off-by: David Howells Signed-off-by: Herbert Xu --- diff --git a/crypto/testmgr.h b/crypto/testmgr.h index 1f5a31f2..1cd62a7 100644 --- a/crypto/testmgr.h +++ b/crypto/testmgr.h @@ -54,7 +54,7 @@ struct cipher_testvec { unsigned short tap[MAX_TAP]; int np; unsigned char also_non_np; - unsigned char fail; + bool fail; unsigned char wk; /* weak key flag */ unsigned char klen; unsigned short ilen; @@ -71,7 +71,7 @@ struct aead_testvec { unsigned char atap[MAX_TAP]; int np; int anp; - unsigned char fail; + bool fail; unsigned char novrfy; /* ccm dec verification failure expected */ unsigned char wk; /* weak key flag */ unsigned char klen; @@ -3018,7 +3018,7 @@ static struct cipher_testvec des_enc_tv_template[] = { "\xb4\x99\x26\xf7\x1f\xe1\xd4\x90", .rlen = 24, }, { /* Weak key */ - .fail = 1, + .fail = true, .wk = 1, .key = "\x01\x01\x01\x01\x01\x01\x01\x01", .klen = 8,