From: Amir Goldstein <amir73il@gmail.com>
Date: Tue, 10 Aug 2021 15:12:17 +0000 (+0300)
Subject: fsnotify: replace igrab() with ihold() on attach connector
X-Git-Tag: accepted/tizen/unified/20230118.172025~6589^2~3
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=09ddbe69c9925b42cb9529f60678c25b241d8b18;p=platform%2Fkernel%2Flinux-rpi.git

fsnotify: replace igrab() with ihold() on attach connector

We must have a reference on inode, so ihold is cheaper.

Link: https://lore.kernel.org/r/20210810151220.285179-2-amir73il@gmail.com
Reviewed-by: Matthew Bobrowski <repnop@google.com>
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Jan Kara <jack@suse.cz>
---

diff --git a/fs/notify/mark.c b/fs/notify/mark.c
index d32ab34..80459db 100644
--- a/fs/notify/mark.c
+++ b/fs/notify/mark.c
@@ -493,8 +493,11 @@ static int fsnotify_attach_connector_to_object(fsnotify_connp_t *connp,
 		conn->fsid.val[0] = conn->fsid.val[1] = 0;
 		conn->flags = 0;
 	}
-	if (conn->type == FSNOTIFY_OBJ_TYPE_INODE)
-		inode = igrab(fsnotify_conn_inode(conn));
+	if (conn->type == FSNOTIFY_OBJ_TYPE_INODE) {
+		inode = fsnotify_conn_inode(conn);
+		ihold(inode);
+	}
+
 	/*
 	 * cmpxchg() provides the barrier so that readers of *connp can see
 	 * only initialized structure