From: Damien Le Moal Date: Sat, 17 Apr 2021 01:10:09 +0000 (+0900) Subject: riscv: Disable data start offset in flat binaries X-Git-Tag: accepted/tizen/unified/20230118.172025~7301^2~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=09accc3a05f7f1a6486f4a278d209ac122289c0b;p=platform%2Fkernel%2Flinux-rpi.git riscv: Disable data start offset in flat binaries uclibc/gcc combined with elf2flt riscv linker file fully resolve the PC relative __global_pointer$ value at compile time and do not generate a relocation entry to set a correct value of the gp register at runtime. As a result, if the flatbin loader offsets the start of the data section, the relative position change between the text and data sections compared to the compile time positions results in an incorrect gp value being used. This causes flatbin executables to crash. Avoid this problem by enabling CONFIG_BINFMT_FLAT_NO_DATA_START_OFFSET automatically when CONFIG_RISCV is enabled and CONFIG_MMU is disabled. Signed-off-by: Damien Le Moal Acked-by: Palmer Dabbelt Signed-off-by: Greg Ungerer --- diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig index 4515a10..add528e 100644 --- a/arch/riscv/Kconfig +++ b/arch/riscv/Kconfig @@ -33,6 +33,7 @@ config RISCV select ARCH_WANT_DEFAULT_TOPDOWN_MMAP_LAYOUT if MMU select ARCH_WANT_FRAME_POINTERS select ARCH_WANT_HUGE_PMD_SHARE if 64BIT + select BINFMT_FLAT_NO_DATA_START_OFFSET if !MMU select CLONE_BACKWARDS select CLINT_TIMER if !MMU select COMMON_CLK