From: Su Hui Date: Mon, 20 Nov 2023 09:10:47 +0000 (+0800) Subject: phy: sunplus: return negative error code in sp_usb_phy_probe X-Git-Tag: v6.6.14~768 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=09aa95c0e7147f810c05301e1999949c5b99d3f6;p=platform%2Fkernel%2Flinux-starfive.git phy: sunplus: return negative error code in sp_usb_phy_probe [ Upstream commit 2a9c713825b3127ece11984abf973672c9779518 ] devm_phy_create() return negative error code, 'ret' should be 'PTR_ERR(phy)' rather than '-PTR_ERR(phy)'. Fixes: 99d9ccd97385 ("phy: usb: Add USB2.0 phy driver for Sunplus SP7021") Signed-off-by: Su Hui Link: https://lore.kernel.org/r/20231120091046.163781-1-suhui@nfschina.com Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- diff --git a/drivers/phy/sunplus/phy-sunplus-usb2.c b/drivers/phy/sunplus/phy-sunplus-usb2.c index 0efe74a..637a5fb 100644 --- a/drivers/phy/sunplus/phy-sunplus-usb2.c +++ b/drivers/phy/sunplus/phy-sunplus-usb2.c @@ -275,7 +275,7 @@ static int sp_usb_phy_probe(struct platform_device *pdev) phy = devm_phy_create(&pdev->dev, NULL, &sp_uphy_ops); if (IS_ERR(phy)) { - ret = -PTR_ERR(phy); + ret = PTR_ERR(phy); return ret; }