From: Miklos Szeredi <mszeredi@suse.cz>
Date: Tue, 6 Mar 2012 12:56:33 +0000 (+0100)
Subject: vfs: fix double put after complete_walk()
X-Git-Tag: v3.3~23^2~2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=097b180ca09b581ef0dc24fbcfc1b227de3875df;p=platform%2Fkernel%2Flinux-amlogic.git

vfs: fix double put after complete_walk()

complete_walk() already puts nd->path, no need to do it again at cleanup time.

This would result in Oopses if triggered, apparently the codepath is not too
well exercised.

Signed-off-by: Miklos Szeredi <mszeredi@suse.cz>
CC: stable@vger.kernel.org
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---

diff --git a/fs/namei.c b/fs/namei.c
index e2ba628..f79aef1 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -2261,7 +2261,7 @@ static struct file *do_last(struct nameidata *nd, struct path *path,
 	/* Why this, you ask?  _Now_ we might have grown LOOKUP_JUMPED... */
 	error = complete_walk(nd);
 	if (error)
-		goto exit;
+		return ERR_PTR(error);
 	error = -EISDIR;
 	if (S_ISDIR(nd->inode->i_mode))
 		goto exit;