From: Julia Lawall Date: Fri, 5 Mar 2010 21:42:47 +0000 (-0800) Subject: drivers/misc/iwmc3200top/main.c: eliminate useless code X-Git-Tag: v2.6.34-rc1~130 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=08d9e7363b87a4c5fb3fc17070607a75a9eb4cc8;p=profile%2Fivi%2Fkernel-x86-ivi.git drivers/misc/iwmc3200top/main.c: eliminate useless code The variable priv is initialized twice to the same (side effect-free) expression. Drop one initialization. A simplified version of the semantic match that finds this problem is: (http://coccinelle.lip6.fr/) // @forall@ idexpression *x; identifier f!=ERR_PTR; @@ x = f(...) ... when != x ( x = f(...,<+...x...+>,...) | * x = f(...) ) // Signed-off-by: Julia Lawall Cc: Tomas Winkler Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/drivers/misc/iwmc3200top/main.c b/drivers/misc/iwmc3200top/main.c index dd0a3913bf6..3b7292a5cea 100644 --- a/drivers/misc/iwmc3200top/main.c +++ b/drivers/misc/iwmc3200top/main.c @@ -597,8 +597,6 @@ static void iwmct_remove(struct sdio_func *func) struct iwmct_work_struct *read_req; struct iwmct_priv *priv = sdio_get_drvdata(func); - priv = sdio_get_drvdata(func); - LOG_INFO(priv, INIT, "enter\n"); sdio_claim_host(func);