From: Andrew Murray Date: Thu, 29 Aug 2019 20:28:36 +0000 (-0600) Subject: coresight: etm4x: use module_param instead of module_param_named X-Git-Tag: v5.4-rc1~133^2~35 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=08d2ddaa585091d555a31d6ed538c6cedba060eb;p=platform%2Fkernel%2Flinux-rpi.git coresight: etm4x: use module_param instead of module_param_named Given that the user-exposed module parameter for 'boot_enable' matches the variable that it sets, let's use module_param instead of module_param_named. Let's also use octal permissions (checkpatch recommends this) and provide a module parameter description. Signed-off-by: Andrew Murray Reviewed-by: Suzuki K Poulose Signed-off-by: Mathieu Poirier Link: https://lore.kernel.org/r/20190829202842.580-12-mathieu.poirier@linaro.org Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/hwtracing/coresight/coresight-etm4x.c b/drivers/hwtracing/coresight/coresight-etm4x.c index ec94688..615bdbf 100644 --- a/drivers/hwtracing/coresight/coresight-etm4x.c +++ b/drivers/hwtracing/coresight/coresight-etm4x.c @@ -34,7 +34,8 @@ #include "coresight-etm-perf.h" static int boot_enable; -module_param_named(boot_enable, boot_enable, int, S_IRUGO); +module_param(boot_enable, int, 0444); +MODULE_PARM_DESC(boot_enable, "Enable tracing on boot"); /* The number of ETMv4 currently registered */ static int etm4_count;