From: Jakub Kicinski <kuba@kernel.org>
Date: Fri, 26 Aug 2022 03:09:34 +0000 (-0700)
Subject: ethtool: strset: report missing ETHTOOL_A_STRINGSET_ID via ext_ack
X-Git-Tag: v6.1-rc5~319^2~313^2~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=08d1d0e78440aa8670492a01cabea732d4beabf5;p=platform%2Fkernel%2Flinux-starfive.git

ethtool: strset: report missing ETHTOOL_A_STRINGSET_ID via ext_ack

Strset needs ETHTOOL_A_STRINGSET_ID, use it as an example of
reporting attrs missing in nests.

Reviewed-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
---

diff --git a/net/ethtool/strset.c b/net/ethtool/strset.c
index 2d51b7a..3f7de54 100644
--- a/net/ethtool/strset.c
+++ b/net/ethtool/strset.c
@@ -167,7 +167,7 @@ static int strset_get_id(const struct nlattr *nest, u32 *val,
 			       get_stringset_policy, extack);
 	if (ret < 0)
 		return ret;
-	if (!tb[ETHTOOL_A_STRINGSET_ID])
+	if (NL_REQ_ATTR_CHECK(extack, nest, tb, ETHTOOL_A_STRINGSET_ID))
 		return -EINVAL;
 
 	*val = nla_get_u32(tb[ETHTOOL_A_STRINGSET_ID]);