From: Markus Jung Date: Fri, 2 Oct 2015 02:09:06 +0000 (+0900) Subject: Fix cppcheck issues in resource-encapsulation dir X-Git-Tag: 1.0.0~64 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=08c12bf33baaa05845d20c0a9f4f332e1b210bf1;p=contrib%2Fiotivity.git Fix cppcheck issues in resource-encapsulation dir This patch fixes the "(error) Returning reference to auto variable" issue reported by cppcheck tool in resource-encapsulation/src/resourceContainer/src dir. Change-Id: Idade3fb288f7571276274cccb30728cf46851ac6 Signed-off-by: Markus Jung Reviewed-on: https://gerrit.iotivity.org/gerrit/3397 Tested-by: jenkins-iotivity Reviewed-by: Madan Lanka (cherry picked from commit 3a681a107a78bd3d36201bcd3cbfcb46500cc813) Reviewed-on: https://gerrit.iotivity.org/gerrit/3473 --- diff --git a/service/resource-container/src/JavaBundleResource.cpp b/service/resource-container/src/JavaBundleResource.cpp index 47228ee..67e71b1 100644 --- a/service/resource-container/src/JavaBundleResource.cpp +++ b/service/resource-container/src/JavaBundleResource.cpp @@ -147,13 +147,14 @@ void JavaBundleResource::handleSetAttributesRequest(RCSResourceAttributes &attrs } } -RCSResourceAttributes & JavaBundleResource::handleGetAttributesRequest(){ - RCSResourceAttributes ret; +RCSResourceAttributes & JavaBundleResource::handleGetAttributesRequest() +{ std::list attrsNames = getAttributeNames(); for(std::list::iterator iterator = attrsNames.begin(); - iterator != attrsNames.end(); ++iterator ){ - ret[*iterator] = handleGetAttributeRequest(*iterator); + iterator != attrsNames.end(); ++iterator ) + { + handleGetAttributeRequest(*iterator); } - return ret; + return BundleResource::getAttributes(); } #endif