From: Jiung Date: Tue, 10 Oct 2017 08:41:19 +0000 (+0900) Subject: Fix bugs detected by static analyzer X-Git-Tag: submit/tizen/20171011.011333^0 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0862cb1c7bce1fda787919c4e9c3020ad4fdeff8;p=platform%2Fcore%2Fapi%2Fasp.git Fix bugs detected by static analyzer Change-Id: I838021fd8f30fd4cca33cf575b8daff7b605a3a7 Signed-off-by: Yu jiung --- diff --git a/src/asp-client.c b/src/asp-client.c index 8cd9565..ec57803 100644 --- a/src/asp-client.c +++ b/src/asp-client.c @@ -270,12 +270,16 @@ void asp_process_seek_search_result(GDBusConnection *connection, seek = get_seek_by_id(search_id); if (!seek) { ASP_LOGD("There's no related seek"); + g_variant_iter_free(iter); + g_free(service_info); + __ASP_LOG_FUNC_END__; return; } client->seek_search_result_cb(error_code,(asp_seek_service_h)seek, service_mac, advertisement_id, (asp_wps_type_e)config_method, instance_name, service_info, service_info_len, status, client->user_data_for_cb_seek_search_result); + g_variant_iter_free(iter); g_free(service_info); __ASP_LOG_FUNC_END__; @@ -449,12 +453,16 @@ void asp_process_session_request(GDBusConnection *connection, advert = get_advert_by_id(adv_id); if (!advert) { ASP_LOGD("There's no related advert"); + g_variant_iter_free(iter); + __ASP_LOG_FUNC_END__; return; } session = get_session_by_id_mac(session_mac, session_id); if (!advert) { ASP_LOGD("There's no related advert"); + g_variant_iter_free(iter); + __ASP_LOG_FUNC_END__; return; } @@ -463,8 +471,8 @@ void asp_process_session_request(GDBusConnection *connection, (bool)get_network_config_pin, network_config_pin, client->user_data_for_cb_session_config_request); } - g_variant_iter_free(iter); + g_variant_iter_free(iter); __ASP_LOG_FUNC_END__; return; } @@ -521,14 +529,16 @@ void asp_process_session_config_request(GDBusConnection *connection, session = get_session_by_id_mac(session_mac, session_id); if (!session) { ASP_LOGD("There's no related session"); + g_variant_iter_free(iter); + __ASP_LOG_FUNC_END__; return; } client->session_config_request_cb(error_code, (asp_session_h)session, (bool)get_pin, config_pin, client->user_data_for_cb_session_config_request); - g_variant_iter_free(iter); + g_variant_iter_free(iter); __ASP_LOG_FUNC_END__; return; } @@ -588,14 +598,16 @@ void asp_process_session_connect_status(GDBusConnection *connection, session = get_session_by_id_mac(session_mac, session_id); if (!session) { ASP_LOGD("There's no related session"); + g_variant_iter_free(iter); + __ASP_LOG_FUNC_END__; return; } client->session_connect_status_cb(error_code, (asp_session_h)session, (asp_connect_status_e)status, deferred_resp, res_len, client->user_data_for_cb_session_connect_status); - g_variant_iter_free(iter); + g_variant_iter_free(iter); __ASP_LOG_FUNC_END__; return; } @@ -655,6 +667,8 @@ void asp_process_session_status(GDBusConnection *connection, session = get_session_by_id_mac(session_mac, session_id); if (!session) { ASP_LOGD("There's no related session"); + g_variant_iter_free(iter); + __ASP_LOG_FUNC_END__; return; } @@ -662,6 +676,7 @@ void asp_process_session_status(GDBusConnection *connection, (asp_session_state_e) state, requested_info, client->user_data_for_cb_session_status); + g_variant_iter_free(iter); __ASP_LOG_FUNC_END__; return; } @@ -724,6 +739,8 @@ void asp_process_session_port_status(GDBusConnection *connection, session = get_session_by_id_mac(session_mac, session_id); if (!session) { ASP_LOGD("There's no related session"); + g_variant_iter_free(iter); + __ASP_LOG_FUNC_END__; return; } @@ -731,6 +748,7 @@ void asp_process_session_port_status(GDBusConnection *connection, ip_address, port, proto, (asp_port_status_e)status, client->user_data_for_cb_session_port_status); + g_variant_iter_free(iter); __ASP_LOG_FUNC_END__; return; }