From: José Bollo <jose.bollo@open.eurogiciel.org>
Date: Tue, 10 Dec 2013 14:01:58 +0000 (+0100)
Subject: chsmack: checking transmute on directories
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=085ea0c621379aca8d597e52c0a0fee2106b0d09;p=framework%2Fsecurity%2Fsmack.git

chsmack: checking transmute on directories

The transmute flag is meaningfull only on directories.
The program now check that the transmute flag is set
only on directories.

Signed-off-by: José Bollo <jose.bollo@open.eurogiciel.org>
---

diff --git a/utils/chsmack.c b/utils/chsmack.c
index b52f75d..84989e1 100644
--- a/utils/chsmack.c
+++ b/utils/chsmack.c
@@ -114,6 +114,8 @@ int main(int argc, char *argv[])
 	static char mmap_buf[SMACK_LABEL_LEN + 1];
 	static int options_map[128];
 
+	struct stat st;
+
 	char *label;
 	int follow_flag = 0;
 	int transmute_flag = 0;
@@ -193,10 +195,19 @@ int main(int argc, char *argv[])
 			}
 
 			if (transmute_flag) {
-				rc = smack_set_label_for_path(argv[i],
-							XATTR_NAME_SMACKTRANSMUTE, follow_flag, "TRUE");
+				rc = follow_flag ?  stat(argv[i], &st) : lstat(argv[i], &st);
 				if (rc < 0)
 					perror(argv[i]);
+				else if (!S_ISDIR(st.st_mode)) {
+					fprintf(stderr, "%s: transmute: not a directory %s\n",
+						basename(argv[0]), argv[i]);
+				}
+				else {
+					rc = smack_set_label_for_path(argv[i],
+								XATTR_NAME_SMACKTRANSMUTE, follow_flag, "TRUE");
+					if (rc < 0)
+						perror(argv[i]);
+				}
 			}
 		}
 	}