From: Yunhee Seo <yuni.seo@samsung.com>
Date: Wed, 14 Feb 2024 10:10:06 +0000 (+0900)
Subject: halcc: Add checking halcc_manifest_add_hal() return value
X-Git-Tag: accepted/tizen/unified/20240306.011956~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=083add881652d78c41a39cbb96f0fcf45412c910;p=platform%2Fhal%2Fapi%2Fcommon.git

halcc: Add checking halcc_manifest_add_hal() return value

If halcc_manifest_add_hal() returns error, halcc_hal should be free.
Omitted handling code is added.

Change-Id: Ic566968760537f2375cd84e25b877115beeaddb3
Signed-off-by: Yunhee Seo <yuni.seo@samsung.com>
---

diff --git a/halcc/src/halcc-parser.c b/halcc/src/halcc-parser.c
index 4b12c2f..53adae4 100644
--- a/halcc/src/halcc-parser.c
+++ b/halcc/src/halcc-parser.c
@@ -264,7 +264,14 @@ static int parse_manifest(xmlNode *node, halcc_manifest *manifest)
 			continue;
 		}
 
-		halcc_manifest_add_hal(manifest, h);
+		ret = halcc_manifest_add_hal(manifest, h);
+		if (ret != 0) {
+			printf("Failed to halcc_manifest_add_hal(), ret=%d\n", ret);
+			halcc_hal_free(h);
+			h = NULL;
+			continue;
+		}
+
 		h = NULL;
 	}