From: Philip Reames <listmail@philipreames.com>
Date: Fri, 26 Feb 2021 19:50:40 +0000 (-0800)
Subject: [cgp] Minor code improvement - reuse an existing named helper [NFC]
X-Git-Tag: llvmorg-14-init~13919
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0832a58e22dedb26c508405fbd4f0cc8de562244;p=platform%2Fupstream%2Fllvm.git

[cgp] Minor code improvement - reuse an existing named helper [NFC]
---

diff --git a/llvm/lib/CodeGen/CodeGenPrepare.cpp b/llvm/lib/CodeGen/CodeGenPrepare.cpp
index f81d097..ed83fad 100644
--- a/llvm/lib/CodeGen/CodeGenPrepare.cpp
+++ b/llvm/lib/CodeGen/CodeGenPrepare.cpp
@@ -1290,9 +1290,9 @@ bool CodeGenPrepare::replaceMathCmpWithIntrinsic(BinaryOperator *BO,
     const BasicBlock *Latch = L->getLoopLatch();
     if (PN->getIncomingValueForBlock(Latch) != BO)
       return false;
-    if (auto *Step = dyn_cast<Instruction>(BO->getOperand(1)))
-      if (L->contains(Step->getParent()))
-        return false;
+    if (!L->isLoopInvariant(BO->getOperand(1)))
+      // Avoid complexities w/loop varying steps.
+      return false;
     // IV increment may have other users than the IV. We do not want to make
     // dominance queries to analyze the legality of moving it towards the cmp,
     // so just check that there is no other users.