From: Robert Bragg <robert@linux.intel.com>
Date: Tue, 27 Jan 2009 11:07:22 +0000 (+0000)
Subject: Removes cogl_color_set_from_4d as it may mislead people.
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=081f2056bc1c1b98337b6a18a37cfe4e76fd3cd4;p=profile%2Fivi%2Fclutter.git

Removes cogl_color_set_from_4d as it may mislead people.

Someone not sure which cogl_color_set_from_* version is "best" may use
set_from_4d because taking doubles implies higher precision. Currently
it doesn't have any advantage.
---

diff --git a/clutter/cogl/cogl-color.h b/clutter/cogl/cogl-color.h
index 05650d3..8303f29 100644
--- a/clutter/cogl/cogl-color.h
+++ b/clutter/cogl/cogl-color.h
@@ -49,23 +49,6 @@ void cogl_color_set_from_4ub (CoglColor *dest,
                               guint8 green,
                               guint8 blue,
                               guint8 alpha);
-/**
- * cogl_color_set_from_4d:
- * @dest: return location for a #CoglColor
- * @red: value of the red channel, between 0 and 1
- * @green: value of the green channel, between 0 and 1
- * @blue: value of the blue channel, between 0 and 1
- * @alpha: value of the alpha channel, between 0 and 1
- *
- * Sets the values of the passed channels into a #CoglColor.
- *
- * Since: 1.0
- */
-void cogl_color_set_from_4d  (CoglColor *dest,
-                              gdouble red,
-                              gdouble green,
-                              gdouble blue,
-                              gdouble alpha);
 
 /**
  * cogl_color_set_from_4f:
diff --git a/clutter/cogl/common/cogl-color.c b/clutter/cogl/common/cogl-color.c
index e4b74c6..1a23d81 100644
--- a/clutter/cogl/common/cogl-color.c
+++ b/clutter/cogl/common/cogl-color.c
@@ -43,21 +43,6 @@ cogl_color_set_from_4ub (CoglColor *dest,
 }
 
 void
-cogl_color_set_from_4d (CoglColor *dest,
-                        gdouble    red,
-                        gdouble    green,
-                        gdouble    blue,
-                        gdouble    alpha)
-{
-  g_return_if_fail (dest != NULL);
-
-  dest->red   = 255 * red;
-  dest->green = 255 * green;
-  dest->blue  = 255 * blue;
-  dest->alpha = 255 * alpha;
-}
-
-void
 cogl_color_set_from_4f (CoglColor *dest,
                         float  red,
                         float  green,