From: Colin Ian King Date: Tue, 12 May 2015 21:37:23 +0000 (+0100) Subject: ti-st: handle null allocation return correctly. X-Git-Tag: v4.14-rc1~5165^2~81 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0810f18fce92afc827d5c7c1d4f146b72b8052d6;p=platform%2Fkernel%2Flinux-rpi.git ti-st: handle null allocation return correctly. static analysis with smatch picked up the following error: get_platform_data() error: potential null dereference 'dt_pdata'. (kzalloc returns null) Instead, the code should return NULL to avoid the following null pointer deference. Also, remove the error message as it is redundant, the caller emits an error message to alert of a failure anyhow. Signed-off-by: Colin Ian King Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/misc/ti-st/st_kim.c b/drivers/misc/ti-st/st_kim.c index 18e7a03..5027b8f 100644 --- a/drivers/misc/ti-st/st_kim.c +++ b/drivers/misc/ti-st/st_kim.c @@ -752,9 +752,8 @@ static struct ti_st_plat_data *get_platform_data(struct device *dev) int len; dt_pdata = kzalloc(sizeof(*dt_pdata), GFP_KERNEL); - if (!dt_pdata) - pr_err("Can't allocate device_tree platform data\n"); + return NULL; dt_property = of_get_property(np, "dev_name", &len); if (dt_property)