From: Stefano Lattarini Date: Sat, 18 Dec 2010 11:58:04 +0000 (+0100) Subject: Improve comments in tests `posixsubst*.test'. X-Git-Tag: v1.11b~461^2~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=080d362b919118033d054cb80b85cffc6d94cab6;p=platform%2Fupstream%2Fautomake.git Improve comments in tests `posixsubst*.test'. * tests/posixsubst-data.test: Improve comment explaining why we try also empty match suffix. * tests/posixsubst-extradist.test: Likewise. * tests/posixsubst-ldadd.test: Likewise. * tests/posixsubst-libraries.test: Likewise. * tests/posixsubst-ltlibraries.test: Likewise. * tests/posixsubst-programs.test: Likewise. * tests/posixsubst-scripts.test: Likewise. * tests/posixsubst-sources.test: Likewise. * tests/posixsubst-tests.test: Likewise. Suggested by Ralf Wildenhues. --- diff --git a/ChangeLog b/ChangeLog index abeaf00..6a27347 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,18 @@ +2010-12-18 Stefano Lattarini + + Improve comments in tests `posixsubst*.test'. + * tests/posixsubst-data.test: Improve comment explaining why we + try also empty match suffix. + * tests/posixsubst-extradist.test: Likewise. + * tests/posixsubst-ldadd.test: Likewise. + * tests/posixsubst-libraries.test: Likewise. + * tests/posixsubst-ltlibraries.test: Likewise. + * tests/posixsubst-programs.test: Likewise. + * tests/posixsubst-scripts.test: Likewise. + * tests/posixsubst-sources.test: Likewise. + * tests/posixsubst-tests.test: Likewise. + Suggested by Ralf Wildenhues. + 2010-12-16 Ralf Wildenhues Fix typos in test comments. diff --git a/tests/posixsubst-data.test b/tests/posixsubst-data.test index f1ffeae..210279f 100755 --- a/tests/posixsubst-data.test +++ b/tests/posixsubst-data.test @@ -36,8 +36,8 @@ bar.data bazzardoz: : > $@ CLEANFILES = bar.data bazzardoz -# Try also with `:=', to ensure the parser is not unduly confused -# into thinking that it's an unportable assignment operator. +# Also try an empty match suffix, to ensure that the `:=' in there is +# not confused by the parser with an unportable assignment operator. dist_foo_DATA = $(t1:=.txt) foo_DATA = $(t2:x=.data) nodist_foo_DATA = $(t3:.y=zardoz) diff --git a/tests/posixsubst-extradist.test b/tests/posixsubst-extradist.test index c3bf970..c9a20bf 100755 --- a/tests/posixsubst-extradist.test +++ b/tests/posixsubst-extradist.test @@ -29,8 +29,8 @@ cat > Makefile.am << 'END' t1 = foo1 foo2 t2 = bar.x t3 = baz-y -# Try also with `:=', to ensure the parser is not unduly confused -# into thinking that it's an unportable assignment operator. +# Also try an empty match suffix, to ensure that the `:=' in there is +# not confused by the parser with an unportable assignment operator. EXTRA_DIST = $(t1:=.c) $(t2:.x=.f) $(t3:-y=ar) bazar bar.f: : > $@ diff --git a/tests/posixsubst-ldadd.test b/tests/posixsubst-ldadd.test index fa3a12c..6eb29f9 100755 --- a/tests/posixsubst-ldadd.test +++ b/tests/posixsubst-ldadd.test @@ -37,8 +37,8 @@ zardoz_PROGRAMS = foo bar noinst_LIBRARIES = libquux1.a libquux2.a libquux3.a -# Try also with `:=', to ensure the parser is not unduly confused -# into thinking that it's an unportable assignment operator. +# Also try an empty match suffix, to ensure that the `:=' in there is +# not confused by the parser with an unportable assignment operator. LDADD = $(u:.lib=.a) bar_LDADD = $(v:=.a) libquux2.a $(w:none=libquux3.a) diff --git a/tests/posixsubst-libraries.test b/tests/posixsubst-libraries.test index 79b96bc..90cc2e5 100755 --- a/tests/posixsubst-libraries.test +++ b/tests/posixsubst-libraries.test @@ -32,8 +32,8 @@ cat > Makefile.am << 'END' foolibs = libfoo1 libfoo2 barlibs = libbaz -# Try also with `:=', to ensure the parser is not unduly confused -# into thinking that it's an unportable assignment operator. +# Also try an empty match suffix, to ensure that the `:=' in there is +# not confused by the parser with an unportable assignment operator. lib_LIBRARIES = $(foolibs:=.a) $(barlibs:z=r.a) libbar.c: diff --git a/tests/posixsubst-ltlibraries.test b/tests/posixsubst-ltlibraries.test index c482db4..93a1d57 100755 --- a/tests/posixsubst-ltlibraries.test +++ b/tests/posixsubst-ltlibraries.test @@ -33,8 +33,8 @@ cat > Makefile.am << 'END' foolibs = libfoo1 libfoo2 barlibs = libbaz -# Try also with `:=', to ensure the parser is not unduly confused -# into thinking that it's an unportable assignment operator. +# Also try an empty match suffix, to ensure that the `:=' in there is +# not confused by the parser with an unportable assignment operator. lib_LTLIBRARIES = $(foolibs:=.la) $(barlibs:z=r.la) libbar.c: diff --git a/tests/posixsubst-programs.test b/tests/posixsubst-programs.test index a8471f6..69252dd 100755 --- a/tests/posixsubst-programs.test +++ b/tests/posixsubst-programs.test @@ -30,8 +30,8 @@ cat > Makefile.am << 'END' t1 = foo1 foo2 t2 = barx bar2 -# Try also with `:=', to ensure the parser is not unduly confused -# into thinking that it's an unportable assignment operator. +# Also try an empty match suffix, to ensure that the `:=' in there is +# not confused by the parser with an unportable assignment operator. bin_PROGRAMS = $(t1:=-p) $(t2:2=y) installcheck-local: diff --git a/tests/posixsubst-scripts.test b/tests/posixsubst-scripts.test index a6f253b..d5fe91e 100755 --- a/tests/posixsubst-scripts.test +++ b/tests/posixsubst-scripts.test @@ -34,8 +34,8 @@ bar1 bar2 quux.pl: : > $@ CLEANFILES = bar1 bar2 quux.pl -# Try also with `:=', to ensure the parser is not unduly confused -# into thinking that it's an unportable assignment operator. +# Also try an empty match suffix, to ensure that the `:=' in there is +# not confused by the parser with an unportable assignment operator. dist_sbin_SCRIPTS = $(t1:=.sh) libexec_SCRIPTS = $(t2:x=) nodist_bin_SCRIPTS = $(t3:-baz=x.pl) diff --git a/tests/posixsubst-sources.test b/tests/posixsubst-sources.test index 97f4e55..14d438d 100755 --- a/tests/posixsubst-sources.test +++ b/tests/posixsubst-sources.test @@ -33,8 +33,8 @@ FOO = foo.cxx BAR = bar__ BAZ = baz. -# Try also with `:=', to ensure the parser is not unduly confused -# into thinking that it's an unportable assignment operator. +# Also try an empty match suffix, to ensure that the `:=' in there is +# not confused by the parser with an unportable assignment operator. foo_SOURCES = main.c $(FOO:.cxx=.c) dist_foo_SOURCES = $(BAR:__=.c) nodist_foo_SOURCES = $(BAZ:=c) diff --git a/tests/posixsubst-tests.test b/tests/posixsubst-tests.test index 98305ae..3fca8f4 100755 --- a/tests/posixsubst-tests.test +++ b/tests/posixsubst-tests.test @@ -34,8 +34,8 @@ foo2.test barz: (echo '#!/bin/sh' && echo 'exit 0') > $@ && chmod a+x $@ CLEANFILES = foo2.test barz # for FreeBSD make -# Try also with `:=', to ensure the parser is not unduly confused -# into thinking that it's an unportable assignment operator. +# Also try an empty match suffix, to ensure that the `:=' in there is +# not confused by the parser with an unportable assignment operator. TESTS = $(t1:=.test) $(t2:x=y) $(t3:2=z) EXTRA_DIST = $(TESTS)