From: Adrian Hunter Date: Wed, 29 Jun 2016 13:24:38 +0000 (+0300) Subject: mmc: sdhci: sdhci_execute_tuning() must delete timer X-Git-Tag: v4.8~337^2~50 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=07c161bcd7ff6d119f828402a776c9e43a50a851;p=platform%2Fkernel%2Flinux-amlogic.git mmc: sdhci: sdhci_execute_tuning() must delete timer sdhci_send_command() starts a timer to catch cases where the host controller fails. The timer is normally deleted when the request completes, but in the case of sdhci_execute_tuning() the request is handled differently and the timer is left running. This goes unnoticed because tuning is done before another command so the timer gets reset then. That should not be relied upon, so make sdhci_execute_tuning() delete the timer. Signed-off-by: Adrian Hunter Signed-off-by: Ulf Hansson --- diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index 6c8cc1a..2ee8bfa 100644 --- a/drivers/mmc/host/sdhci.c +++ b/drivers/mmc/host/sdhci.c @@ -2057,6 +2057,7 @@ static int sdhci_execute_tuning(struct mmc_host *mmc, u32 opcode) sdhci_send_command(host, &cmd); host->cmd = NULL; + sdhci_del_timer(host, &mrq); spin_unlock_irqrestore(&host->lock, flags); /* Wait for Buffer Read Ready interrupt */