From: Dinghao Liu Date: Mon, 12 Apr 2021 05:49:07 +0000 (+0800) Subject: usb: cdns3: Fix runtime PM imbalance on error X-Git-Tag: v5.15~960^2~1^2~5 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=07adc0225484fc199e3dc15ec889f75f498c4fca;p=platform%2Fkernel%2Flinux-starfive.git usb: cdns3: Fix runtime PM imbalance on error When cdns3_gadget_start() fails, a pairing PM usage counter decrement is needed to keep the counter balanced. Signed-off-by: Dinghao Liu Link: https://lore.kernel.org/r/20210412054908.7975-1-dinghao.liu@zju.edu.cn Signed-off-by: Peter Chen --- diff --git a/drivers/usb/cdns3/cdns3-gadget.c b/drivers/usb/cdns3/cdns3-gadget.c index 9b1bd41..a8b7b50 100644 --- a/drivers/usb/cdns3/cdns3-gadget.c +++ b/drivers/usb/cdns3/cdns3-gadget.c @@ -3268,8 +3268,10 @@ static int __cdns3_gadget_init(struct cdns *cdns) pm_runtime_get_sync(cdns->dev); ret = cdns3_gadget_start(cdns); - if (ret) + if (ret) { + pm_runtime_put_sync(cdns->dev); return ret; + } /* * Because interrupt line can be shared with other components in