From: rohit singh <rohit.singh@samsung.com>
Date: Thu, 10 Jun 2021 05:21:07 +0000 (+0530)
Subject: Fix dereferencing before NULL check issue.
X-Git-Tag: submit/tizen/20210615.073530^2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=079dcc8924d944f9575e5019f5609c0ff7aca3ed;p=platform%2Fcore%2Fapi%2Fuser-awareness.git

Fix dereferencing before NULL check issue.

Change-Id: Ib106ef87a6d64baeebd4f803434ea4ff49595dac
Signed-off-by: rohit.singh <rohit.singh@samsung.com>
---

diff --git a/src/user-awareness-payload.c b/src/user-awareness-payload.c
index d7f66f7..ac116b6 100755
--- a/src/user-awareness-payload.c
+++ b/src/user-awareness-payload.c
@@ -419,19 +419,25 @@ ua_payload_info_s* _ua_payload_clone(ua_payload_info_s *org_payload)
 	payload->extension_value2 = org_payload->extension_value2;
 
 	payload->device_uid_len = org_payload->device_uid_len;
-	payload->device_uid = g_memdup(org_payload->device_uid, org_payload->device_uid_len);
-	if (!payload->device_uid && org_payload->device_uid) {
-		UA_ERR("g_malloc0 failed");
-		_ua_free_ua_payload_info_s(payload);
-		return NULL;
+
+	if (org_payload->device_uid) {
+		payload->device_uid = g_memdup(org_payload->device_uid, org_payload->device_uid_len);
+		if (!payload->device_uid) {
+			UA_ERR("g_memdup failed");
+			_ua_free_ua_payload_info_s(payload);
+			return NULL;
+		}
 	}
 
 	user_data_len = UA_BLE_PAYLOAD_DEVICE_UID_MAX_LEN - 1 - org_payload->device_uid_len;
-	payload->user_data = g_memdup(org_payload->user_data, user_data_len);
-	if (!payload->user_data && org_payload->user_data) {
-		UA_ERR("g_malloc0 failed");
-		_ua_free_ua_payload_info_s(payload);
-		return NULL;
+
+	if (org_payload->user_data) {
+		payload->user_data = g_memdup(org_payload->user_data, user_data_len);
+		if (!payload->user_data) {
+			UA_ERR("g_memdup failed");
+			_ua_free_ua_payload_info_s(payload);
+			return NULL;
+		}
 	}
 
 	FUNC_EXIT;