From: Johannes Thumshirn Date: Thu, 30 Mar 2023 10:43:50 +0000 (-0700) Subject: btrfs: use __bio_add_page for adding a single page in repair_one_sector X-Git-Tag: v6.6.7~2632^2~87 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=078e4cf5dbedb3d407417a10ac5918dca6ca156a;p=platform%2Fkernel%2Flinux-starfive.git btrfs: use __bio_add_page for adding a single page in repair_one_sector The btrfs repair bio submission code uses bio_add_page() to add a page to a newly created bio. bio_add_page() can fail, but the return value is never checked. Use __bio_add_page() as adding a single page to a newly created bio is guaranteed to succeed. This brings us a step closer to marking bio_add_page() as __must_check. Reviewed-by: Damien Le Moal Signed-off-by: Johannes Thumshirn Reviewed-by: David Sterba Signed-off-by: David Sterba --- diff --git a/fs/btrfs/bio.c b/fs/btrfs/bio.c index cf09c62..89c1a0d 100644 --- a/fs/btrfs/bio.c +++ b/fs/btrfs/bio.c @@ -227,7 +227,7 @@ static struct btrfs_failed_bio *repair_one_sector(struct btrfs_bio *failed_bbio, repair_bio = bio_alloc_bioset(NULL, 1, REQ_OP_READ, GFP_NOFS, &btrfs_repair_bioset); repair_bio->bi_iter.bi_sector = failed_bbio->saved_iter.bi_sector; - bio_add_page(repair_bio, bv->bv_page, bv->bv_len, bv->bv_offset); + __bio_add_page(repair_bio, bv->bv_page, bv->bv_len, bv->bv_offset); repair_bbio = btrfs_bio(repair_bio); btrfs_bio_init(repair_bbio, failed_bbio->inode, NULL, fbio);