From: Sander de Smalen Date: Tue, 12 May 2020 10:23:38 +0000 (+0100) Subject: [CodeGen][SVE] Add patterns for whole vector predicate select X-Git-Tag: llvmorg-12-init~6300 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=077d2d6802efefe6680cbae78f90e90ef7f04134;p=platform%2Fupstream%2Fllvm.git [CodeGen][SVE] Add patterns for whole vector predicate select Added patterns to implement `select i1 %p, %a, %b` Reviewed By: efriedma Tags: #llvm Differential Revision: https://reviews.llvm.org/D79356 --- diff --git a/llvm/lib/Target/AArch64/AArch64ISelLowering.cpp b/llvm/lib/Target/AArch64/AArch64ISelLowering.cpp index 3270ba2..899b18f 100644 --- a/llvm/lib/Target/AArch64/AArch64ISelLowering.cpp +++ b/llvm/lib/Target/AArch64/AArch64ISelLowering.cpp @@ -876,6 +876,7 @@ AArch64TargetLowering::AArch64TargetLowering(const TargetMachine &TM, for (MVT VT : MVT::integer_scalable_vector_valuetypes()) { if (isTypeLegal(VT)) { setOperationAction(ISD::SPLAT_VECTOR, VT, Custom); + setOperationAction(ISD::SELECT, VT, Custom); setOperationAction(ISD::SDIV, VT, Custom); setOperationAction(ISD::UDIV, VT, Custom); setOperationAction(ISD::SMIN, VT, Custom); @@ -893,6 +894,7 @@ AArch64TargetLowering::AArch64TargetLowering(const TargetMachine &TM, for (MVT VT : MVT::fp_scalable_vector_valuetypes()) { if (isTypeLegal(VT)) { setOperationAction(ISD::SPLAT_VECTOR, VT, Custom); + setOperationAction(ISD::SELECT, VT, Custom); } } } @@ -5710,6 +5712,14 @@ SDValue AArch64TargetLowering::LowerSELECT(SDValue Op, SDValue FVal = Op->getOperand(2); SDLoc DL(Op); + EVT Ty = Op.getValueType(); + if (Ty.isScalableVector()) { + SDValue TruncCC = DAG.getNode(ISD::TRUNCATE, DL, MVT::i1, CCVal); + MVT PredVT = MVT::getVectorVT(MVT::i1, Ty.getVectorElementCount()); + SDValue SplatPred = DAG.getNode(ISD::SPLAT_VECTOR, DL, PredVT, TruncCC); + return DAG.getNode(ISD::VSELECT, DL, Ty, SplatPred, TVal, FVal); + } + // Optimize {s|u}{add|sub|mul}.with.overflow feeding into a select // instruction. if (ISD::isOverflowIntrOpRes(CCVal)) { diff --git a/llvm/test/CodeGen/AArch64/select-sve.ll b/llvm/test/CodeGen/AArch64/select-sve.ll new file mode 100644 index 0000000..b0959d2 --- /dev/null +++ b/llvm/test/CodeGen/AArch64/select-sve.ll @@ -0,0 +1,134 @@ +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: llc -mtriple=aarch64-linux-gnu -mattr=+sve -verify-machineinstrs < %s | FileCheck %s + +define @select_nxv16i8(i1 %cond, %a, %b) { +; CHECK-LABEL: select_nxv16i8: +; CHECK: // %bb.0: +; CHECK-NEXT: // kill: def $w0 killed $w0 def $x0 +; CHECK-NEXT: sbfx x8, x0, #0, #1 +; CHECK-NEXT: whilelo p0.b, xzr, x8 +; CHECK-NEXT: sel z0.b, p0, z0.b, z1.b +; CHECK-NEXT: ret + %res = select i1 %cond, %a, %b + ret %res +} + +define @select_nxv8i16(i1 %cond, %a, %b) { +; CHECK-LABEL: select_nxv8i16: +; CHECK: // %bb.0: +; CHECK-NEXT: // kill: def $w0 killed $w0 def $x0 +; CHECK-NEXT: sbfx x8, x0, #0, #1 +; CHECK-NEXT: whilelo p0.h, xzr, x8 +; CHECK-NEXT: sel z0.h, p0, z0.h, z1.h +; CHECK-NEXT: ret + %res = select i1 %cond, %a, %b + ret %res +} + +define @select_nxv4i32(i1 %cond, %a, %b) { +; CHECK-LABEL: select_nxv4i32: +; CHECK: // %bb.0: +; CHECK-NEXT: // kill: def $w0 killed $w0 def $x0 +; CHECK-NEXT: sbfx x8, x0, #0, #1 +; CHECK-NEXT: whilelo p0.s, xzr, x8 +; CHECK-NEXT: sel z0.s, p0, z0.s, z1.s +; CHECK-NEXT: ret + %res = select i1 %cond, %a, %b + ret %res +} + +define @select_nxv2i64(i1 %cond, %a, %b) { +; CHECK-LABEL: select_nxv2i64: +; CHECK: // %bb.0: +; CHECK-NEXT: // kill: def $w0 killed $w0 def $x0 +; CHECK-NEXT: sbfx x8, x0, #0, #1 +; CHECK-NEXT: whilelo p0.d, xzr, x8 +; CHECK-NEXT: sel z0.d, p0, z0.d, z1.d +; CHECK-NEXT: ret + %res = select i1 %cond, %a, %b + ret %res +} + +define @select_nxv8f16(i1 %cond, %a, %b) { +; CHECK-LABEL: select_nxv8f16: +; CHECK: // %bb.0: +; CHECK-NEXT: // kill: def $w0 killed $w0 def $x0 +; CHECK-NEXT: sbfx x8, x0, #0, #1 +; CHECK-NEXT: whilelo p0.h, xzr, x8 +; CHECK-NEXT: sel z0.h, p0, z0.h, z1.h +; CHECK-NEXT: ret + %res = select i1 %cond, %a, %b + ret %res +} + +define @select_nxv4f32(i1 %cond, %a, %b) { +; CHECK-LABEL: select_nxv4f32: +; CHECK: // %bb.0: +; CHECK-NEXT: // kill: def $w0 killed $w0 def $x0 +; CHECK-NEXT: sbfx x8, x0, #0, #1 +; CHECK-NEXT: whilelo p0.s, xzr, x8 +; CHECK-NEXT: sel z0.s, p0, z0.s, z1.s +; CHECK-NEXT: ret + %res = select i1 %cond, %a, %b + ret %res +} + +define @select_nxv2f64(i1 %cond, %a, %b) { +; CHECK-LABEL: select_nxv2f64: +; CHECK: // %bb.0: +; CHECK-NEXT: // kill: def $w0 killed $w0 def $x0 +; CHECK-NEXT: sbfx x8, x0, #0, #1 +; CHECK-NEXT: whilelo p0.d, xzr, x8 +; CHECK-NEXT: sel z0.d, p0, z0.d, z1.d +; CHECK-NEXT: ret + %res = select i1 %cond, %a, %b + ret %res +} + +define @select_nxv16i1(i1 %cond, %a, %b) { +; CHECK-LABEL: select_nxv16i1: +; CHECK: // %bb.0: +; CHECK-NEXT: // kill: def $w0 killed $w0 def $x0 +; CHECK-NEXT: sbfx x8, x0, #0, #1 +; CHECK-NEXT: whilelo p2.b, xzr, x8 +; CHECK-NEXT: sel p0.b, p2, p0.b, p1.b +; CHECK-NEXT: ret + %res = select i1 %cond, %a, %b + ret %res +} + +define @select_nxv8i1(i1 %cond, %a, %b) { +; CHECK-LABEL: select_nxv8i1: +; CHECK: // %bb.0: +; CHECK-NEXT: // kill: def $w0 killed $w0 def $x0 +; CHECK-NEXT: sbfx x8, x0, #0, #1 +; CHECK-NEXT: whilelo p2.h, xzr, x8 +; CHECK-NEXT: sel p0.b, p2, p0.b, p1.b +; CHECK-NEXT: ret + %res = select i1 %cond, %a, %b + ret %res +} + +define @select_nxv4i1(i1 %cond, %a, %b) { +; CHECK-LABEL: select_nxv4i1: +; CHECK: // %bb.0: +; CHECK-NEXT: // kill: def $w0 killed $w0 def $x0 +; CHECK-NEXT: sbfx x8, x0, #0, #1 +; CHECK-NEXT: whilelo p2.s, xzr, x8 +; CHECK-NEXT: sel p0.b, p2, p0.b, p1.b +; CHECK-NEXT: ret + %res = select i1 %cond, %a, %b + ret %res +} + +define @select_nxv2i1(i1 %cond, %a, %b) { +; CHECK-LABEL: select_nxv2i1: +; CHECK: // %bb.0: +; CHECK-NEXT: // kill: def $w0 killed $w0 def $x0 +; CHECK-NEXT: sbfx x8, x0, #0, #1 +; CHECK-NEXT: whilelo p2.d, xzr, x8 +; CHECK-NEXT: sel p0.b, p2, p0.b, p1.b +; CHECK-NEXT: ret + %res = select i1 %cond, %a, %b + ret %res +}