From: Peter Zijlstra Date: Thu, 17 Dec 2009 12:16:31 +0000 (+0100) Subject: sched: Fix broken assertion X-Git-Tag: upstream/snapshot3+hdmi~16054^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=077614ee1e93245a3b9a4e1213659405dbeb0ba6;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git sched: Fix broken assertion There's a preemption race in the set_task_cpu() debug check in that when we get preempted after setting task->state we'd still be on the rq proper, but fail the test. Check for preempted tasks, since those are always on the RQ. Signed-off-by: Peter Zijlstra LKML-Reference: <20091217121830.137155561@chello.nl> Signed-off-by: Ingo Molnar --- diff --git a/kernel/sched.c b/kernel/sched.c index 7be88a7..720df108 100644 --- a/kernel/sched.c +++ b/kernel/sched.c @@ -2041,7 +2041,8 @@ void set_task_cpu(struct task_struct *p, unsigned int new_cpu) * We should never call set_task_cpu() on a blocked task, * ttwu() will sort out the placement. */ - WARN_ON_ONCE(p->state != TASK_RUNNING && p->state != TASK_WAKING); + WARN_ON_ONCE(p->state != TASK_RUNNING && p->state != TASK_WAKING && + !(task_thread_info(p)->preempt_count & PREEMPT_ACTIVE)); #endif trace_sched_migrate_task(p, new_cpu);