From: Thomas Vander Stichele <thomas@apestaart.org>
Date: Sat, 29 Apr 2006 13:09:52 +0000 (+0000)
Subject: tests/check/elements/audioconvert.c: interpret the out[] buffer in the order the... 
X-Git-Tag: 1.19.3~511^2~11960
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0774022d5bac29620ce5984a9e305bd9474a7e20;p=platform%2Fupstream%2Fgstreamer.git

tests/check/elements/audioconvert.c: interpret the out[] buffer in the order the bytes are actually put in, which is ...

Original commit message from CVS:

* tests/check/elements/audioconvert.c: (verify_convert),
(GST_START_TEST):
interpret the out[] buffer in the order the bytes are actually
put in, which is LITTLE_ENDIAN, not BYTE_ORDER.
Other tests should use BYTE_ORDER since the array is filled in
with actual values
---

diff --git a/ChangeLog b/ChangeLog
index e22eaac..f86cb88 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -2,6 +2,15 @@
 
 	* tests/check/elements/audioconvert.c: (verify_convert),
 	(GST_START_TEST):
+	  interpret the out[] buffer in the order the bytes are actually
+	  put in, which is LITTLE_ENDIAN, not BYTE_ORDER.
+	  Other tests should use BYTE_ORDER since the array is filled in
+	  with actual values
+
+2006-04-29  Thomas Vander Stichele  <thomas at apestaart dot org>
+
+	* tests/check/elements/audioconvert.c: (verify_convert),
+	(GST_START_TEST):
 	  when a test fails, give an indication of which it is
 
 2006-04-29  Thomas Vander Stichele  <thomas at apestaart dot org>
diff --git a/tests/check/elements/audioconvert.c b/tests/check/elements/audioconvert.c
index b1dcaf0..6172abe 100644
--- a/tests/check/elements/audioconvert.c
+++ b/tests/check/elements/audioconvert.c
@@ -308,11 +308,13 @@ GST_START_TEST (test_int_conversion)
   {
     gint8 in[] = { 0, 1, 127 };
     guint8 out[] = { 0x00, 0x00, 0x00, 0x00, 0x00, 0x01, 0x00, 0x00, 0x7f };
+    /* out has the bytes in little-endian, so that's how they should be
+     * interpreted during conversion */
 
     RUN_CONVERSION ("8 to 24 signed", in, get_int_caps (1, "BYTE_ORDER", 8, 8,
-            TRUE), out, get_int_caps (1, "BYTE_ORDER", 24, 24, TRUE)
+            TRUE), out, get_int_caps (1, "LITTLE_ENDIAN", 24, 24, TRUE)
         );
-    RUN_CONVERSION ("24 signed to 8", out, get_int_caps (1, "BYTE_ORDER", 24,
+    RUN_CONVERSION ("24 signed to 8", out, get_int_caps (1, "LITTLE_ENDIAN", 24,
             24, TRUE), in, get_int_caps (1, "BYTE_ORDER", 8, 8, TRUE)
         );
   }