From: Tim-Philipp Müller <tim@centricular.com>
Date: Tue, 11 Mar 2014 21:44:39 +0000 (+0000)
Subject: pad: simplify gst_pad_link_get_name() and fix Since marker
X-Git-Tag: 1.3.1~112
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=075cc42f8830945b46f8630b9990257dcfe1f7b9;p=platform%2Fupstream%2Fgstreamer.git

pad: simplify gst_pad_link_get_name() and fix Since marker

Has added benefit that compiler might warn if more values
are added to the enum.
---

diff --git a/gst/gstpad.c b/gst/gstpad.c
index 2fe1bdf..5b5c9c4 100644
--- a/gst/gstpad.c
+++ b/gst/gstpad.c
@@ -259,17 +259,28 @@ gst_flow_to_quark (GstFlowReturn ret)
  *
  * Returns: a static string with the name of the pad-link return.
  *
- * Since: 1.3.1
+ * Since: 1.4
  */
 const gchar *
 gst_pad_link_get_name (GstPadLinkReturn ret)
 {
-  static const gchar *names[(-(GST_PAD_LINK_REFUSED)) + 1] = {
-    "ok", "wrong hierarchy", "was linked", "wrong direction", "no format",
-    "incompatible scheduling", "refused"
-  };
-  ret = CLAMP (ret, GST_PAD_LINK_REFUSED, GST_PAD_LINK_OK);
-  return names[-ret];
+  switch (ret) {
+    case GST_PAD_LINK_OK:
+      return "ok";
+    case GST_PAD_LINK_WRONG_HIERARCHY:
+      return "wrong hierarchy";
+    case GST_PAD_LINK_WAS_LINKED:
+      return "was linked";
+    case GST_PAD_LINK_WRONG_DIRECTION:
+      return "wrong direction";
+    case GST_PAD_LINK_NOFORMAT:
+      return "no common format";
+    case GST_PAD_LINK_NOSCHED:
+      return "incompatible scheduling";
+    case GST_PAD_LINK_REFUSED:
+      return "refused";
+  }
+  g_return_val_if_reached ("unknown");
 }
 
 #define _do_init \