From: Oliver Neukum <oneukum@suse.com>
Date: Thu, 12 May 2022 13:41:41 +0000 (+0100)
Subject: media: ttusbir: avoid unnecessary usb_unlink_urb()
X-Git-Tag: v6.1-rc5~729^2~400
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=07456325a3c176d69e917cb0aa8cab846d9a6977;p=platform%2Fkernel%2Flinux-starfive.git

media: ttusbir: avoid unnecessary usb_unlink_urb()

While the completion handler is running,
usb_unlink_urb() on yourself is a NOP. Remove it.

Signed-off-by: Oliver Neukum <oneukum@suse.com>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
---

diff --git a/drivers/media/rc/ttusbir.c b/drivers/media/rc/ttusbir.c
index a8009dc..560a26f 100644
--- a/drivers/media/rc/ttusbir.c
+++ b/drivers/media/rc/ttusbir.c
@@ -90,7 +90,6 @@ static void ttusbir_bulk_complete(struct urb *urb)
 	case -ECONNRESET:
 	case -ENOENT:
 	case -ESHUTDOWN:
-		usb_unlink_urb(urb);
 		return;
 	case -EPIPE:
 	default:
@@ -166,7 +165,6 @@ static void ttusbir_urb_complete(struct urb *urb)
 	case -ECONNRESET:
 	case -ENOENT:
 	case -ESHUTDOWN:
-		usb_unlink_urb(urb);
 		return;
 	case -EPIPE:
 	default: