From: Colin Ian King Date: Thu, 29 Sep 2016 17:32:12 +0000 (+0100) Subject: ASoC: Intel: Skylake: fix memory leak of module on error exit path X-Git-Tag: v5.15~12637^2~4^2~13^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=0730bd2e2ade00d88647b13a0c17cde254ddf56e;p=platform%2Fkernel%2Flinux-starfive.git ASoC: Intel: Skylake: fix memory leak of module on error exit path Currently there is a memory leak of module on a ENOMEM return path. Fix this by kfree'ing module before returning. Signed-off-by: Colin Ian King Signed-off-by: Mark Brown --- diff --git a/sound/soc/intel/skylake/skl-sst-utils.c b/sound/soc/intel/skylake/skl-sst-utils.c index 1aa0f37..3fe939c 100644 --- a/sound/soc/intel/skylake/skl-sst-utils.c +++ b/sound/soc/intel/skylake/skl-sst-utils.c @@ -349,8 +349,10 @@ int snd_skl_parse_uuids(struct sst_dsp *ctx, const struct firmware *fw, module->max_instance = mod_entry->instance_max_count; size = sizeof(int) * mod_entry->instance_max_count; module->instance_id = devm_kzalloc(ctx->dev, size, GFP_KERNEL); - if (!module->instance_id) + if (!module->instance_id) { + kfree(module); return -ENOMEM; + } list_add_tail(&module->list, &skl->uuid_list);